WebTransportDatagramsWritable and friends#44383
Conversation
chrisdavidmills
left a comment
There was a problem hiding this comment.
Hi @hamishwillee! I've read through all of these and provided some commentary. Looking mostly pretty good and makes sense.
|
Thanks @chrisdavidmills - Accepted almost all of them. Should be good for another look. |
aacf0d8 to
b775180
Compare
b775180 to
b7dcb88
Compare
|
@chrisdavidmills I have reapplied all your suggestions. Should be ready for another look now. |
chrisdavidmills
left a comment
There was a problem hiding this comment.
@hamishwillee, OK, this seems good to go, except for the weird issue I slacked you about concerning the code listing that seems broken in https://pr44383.review.mdn.allizom.net/en-US/docs/Web/API/WebTransport/datagrams#examples (the page no longer seems listed in the list of changed files.)
Co-Authored-By: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
f208a59 to
bb3408b
Compare
@chrisdavidmills Thanks for the review! Looking at the odd PR output it appears to have been caused by a missing end to a code block - I can't explain why this isn't being generated, but I can confirm the source markup is fine and the local rendering does not have this flaw. |
This documents most of the new
WebTransportsupport for prioritizing streams/datagrams within asendGroupbased onsendOrderfor the respective stream objects - such asWebTransportDatagramsWritable. This is recently implemented in Safari.I started on this when reviewing #44317 because that wants to refer to an undocumented method I needed to understand. Talking about pulling a thread...
Anyway, I believe this is correct and useful. The only thing missing is the stream equivalent of
WebTransportDatagramsWritable-WebTransportSendStream.Fixes #44273