Test cargo package on more platforms#192
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the platforms on which cargo package is tested for the mupdf-sys package. The change increases test coverage from a single platform to three platforms, improving confidence in the package's portability.
Changes:
- Modified the condition for running
cargo packagetest from only running onubuntu-latestto running on all matrix platforms exceptwindows-2025
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a9b0923 to
2e449c5
Compare
2e449c5 to
7efa483
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
23e643a to
b243c12
Compare
ginnyTheCat
reviewed
Jan 18, 2026
| println!("cargo:rerun-if-changed={}", path.display()); | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This is actually already done by the cc crate so we can even skip this step.
ginnyTheCat
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.