Skip removing nodes in <code>#647
Merged
Merged
Conversation
gijsk
requested changes
Nov 19, 2020
gijsk
left a comment
Contributor
There was a problem hiding this comment.
This looks good in principle, just one nit around the use of _hasAncestorTag. Thanks!
(And apologies for the slowness, things are rather... hectic... both at work and in my own life.)
| return false; | ||
| } | ||
|
|
||
| if (this._hasAncestorTag(node, "code", -2)) { |
Contributor
There was a problem hiding this comment.
Why -2 ? In the other change you didn't pass a maxDepth argument at all. It also looks like passing 0 or -2 is functionally equivalent, so this is a bit confusing. Can you clarify, or maybe change to not pass this if it doesn't make a difference? Thanks!
Contributor
Author
|
nw with response time. Thank you for doing open-source projects. I've removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically all syntax highlighters wrap comments in code blocks in
<span class="comment">// some comment</span>.And because word
commentis correctly inREGEXPS.unlikelyCandidatesandREGEXPS.negativethey get removed. But those should be kept as it is valid content.This PR fixes the issue by disabling removing of nodes in
<code>.test url: https://v8.dev/blog/emscripten-standalone-wasm