Skip to content

Handle JSONLD arrays (fixes #908)#947

Merged
gijsk merged 2 commits into
mozilla:mainfrom
ysuhaas:ysuhaas-908
Jan 16, 2025
Merged

Handle JSONLD arrays (fixes #908)#947
gijsk merged 2 commits into
mozilla:mainfrom
ysuhaas:ysuhaas-908

Conversation

@ysuhaas

@ysuhaas ysuhaas commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

This code change:

  • Adds handling for the case where the <script type="application/ld+json"> element contains an array of objects to correctly parse the metadata from the first available node

Fixes #908

@gijsk gijsk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you, also for the test!

@gijsk gijsk merged commit 118f015 into mozilla:main Jan 16, 2025
mislav added a commit to mislav/go-readability that referenced this pull request Jun 23, 2025
This ports "Handle JSONLD arrays" (mozilla/readability#947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

if JSONLD is array of objects, its metadata are not processed

2 participants