Skip to content

Add Naver protocol support#2610

Merged
IvanNardi merged 1 commit into
ntop:devfrom
0xA50C1A1:new-proto/naver
Nov 1, 2024
Merged

Add Naver protocol support#2610
IvanNardi merged 1 commit into
ntop:devfrom
0xA50C1A1:new-proto/naver

Conversation

@0xA50C1A1

Copy link
Copy Markdown
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Naver is kind of a South Korean Google.

@IvanNardi IvanNardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@IvanNardi

Copy link
Copy Markdown
Collaborator

Rebased...

@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2024

Copy link
Copy Markdown

@IvanNardi IvanNardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. You did the right thing with the pcap in the first version, and the workaround for the big-endian issue is perfect. Thank you

@IvanNardi IvanNardi merged commit 137d87f into ntop:dev Nov 1, 2024
@0xA50C1A1 0xA50C1A1 deleted the new-proto/naver branch November 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants