Skip to content

Remove duplicate ALPS extension#2821

Merged
IvanNardi merged 2 commits into
ntop:devfrom
tuliperis:dupe
May 19, 2025
Merged

Remove duplicate ALPS extension#2821
IvanNardi merged 2 commits into
ntop:devfrom
tuliperis:dupe

Conversation

@tuliperis

Copy link
Copy Markdown
Contributor

Please sign (check) the below before submitting the Pull Request:

Link to the related issue:

Describe changes:

  • Removed duplicate ALPS extension and changed from wireshark comment to extension name

@tuliperis

Copy link
Copy Markdown
Contributor Author

Related to this PR, would removing extension 65037 (ECH) be ok as well from the allowed_non_iana_extensions array? It is now listed in https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml

@IvanNardi

Copy link
Copy Markdown
Collaborator

Related to this PR, would removing extension 65037 (ECH) be ok as well from the allowed_non_iana_extensions array? It is now listed in https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml

You can remove it, but you need to add the equivalent excpetion a few lines below. Soemthing like:
from:

if(extension_id > 59 && extension_id != 65281)

to

if(extension_id > 59 && extension_id != 65281 &&  extension_id !=65037 /* ECH */)

@kriztalz

@sonarqubecloud

Copy link
Copy Markdown

@IvanNardi

Copy link
Copy Markdown
Collaborator

@tuliperis

Copy link
Copy Markdown
Contributor Author

@kriztalz, could you sign the ntop Contributor License Agreement at https://github.com/ntop/legal/blob/main/individual-contributor-licence-agreement.md, please?

I've completed it and sent it by email this morning!

@IvanNardi

Copy link
Copy Markdown
Collaborator

@kriztalz, could you sign the ntop Contributor License Agreement at https://github.com/ntop/legal/blob/main/individual-contributor-licence-agreement.md, please?

I've completed it and sent it by email this morning!

Sorry, could you send it again at deri@ntop.org or, better, fill in the online form, please? @kriztalz
Sorry for the inconvenience

@tuliperis

Copy link
Copy Markdown
Contributor Author

@kriztalz, could you sign the ntop Contributor License Agreement at https://github.com/ntop/legal/blob/main/individual-contributor-licence-agreement.md, please?

I've completed it and sent it by email this morning!

Sorry, could you send it again at deri@ntop.org or, better, fill in the online form, please? @kriztalz Sorry for the inconvenience

Done!

@IvanNardi IvanNardi merged commit f8869cd into ntop:dev May 19, 2025
31 checks passed
@IvanNardi

Copy link
Copy Markdown
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants