Improve BFCP detection#2844
Merged
Merged
Conversation
Collaborator
|
@0xA50C1A1, I am facing some issue locally with this PR... could you try to rebase, please? |
Contributor
Author
Try it now, hope it works. |
Collaborator
|
@0xA50C1A1, I merged the two traces. Could you take a look if everything is still fine, please? |
|
Contributor
Author
Thanks, everything looks ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Please sign (check) the below before submitting the Pull Request:
Link to the related issue: #2745
Describe changes:
Payload Lengthfield to ensure it’s correct.primitivefield.Unfortunately, I couldn't merge the PCAP examples as ndpiReader throws an error when trying to read the final file. I’ve included two files: bfcp_tcp.pcapng and bfcp_udp.pcapng.