Skip to content

Improve BFCP detection#2844

Merged
IvanNardi merged 3 commits into
ntop:devfrom
0xA50C1A1:bfcp
May 22, 2025
Merged

Improve BFCP detection#2844
IvanNardi merged 3 commits into
ntop:devfrom
0xA50C1A1:bfcp

Conversation

@0xA50C1A1

Copy link
Copy Markdown
Contributor

Please sign (check) the below before submitting the Pull Request:

Link to the related issue: #2745

Describe changes:

  • Added a check for the Payload Length field to ensure it’s correct.
  • Fixed the validation for the primitive field.
  • Added a valid PCAP sample for BFCP over TCP, sourced from a libbfcp example.

Unfortunately, I couldn't merge the PCAP examples as ndpiReader throws an error when trying to read the final file. I’ve included two files: bfcp_tcp.pcapng and bfcp_udp.pcapng.

@IvanNardi

Copy link
Copy Markdown
Collaborator

@0xA50C1A1, I am facing some issue locally with this PR... could you try to rebase, please?

@0xA50C1A1

Copy link
Copy Markdown
Contributor Author

@0xA50C1A1, I am facing some issue locally with this PR... could you try to rebase, please?

Try it now, hope it works.

@IvanNardi

Copy link
Copy Markdown
Collaborator

@0xA50C1A1, I merged the two traces. Could you take a look if everything is still fine, please?

@sonarqubecloud

Copy link
Copy Markdown

@0xA50C1A1

Copy link
Copy Markdown
Contributor Author

@0xA50C1A1, I merged the two traces. Could you take a look if everything is still fine, please?

Thanks, everything looks ok.

@IvanNardi IvanNardi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@IvanNardi IvanNardi merged commit 90b5f68 into ntop:dev May 22, 2025
30 of 31 checks passed
@0xA50C1A1 0xA50C1A1 deleted the bfcp branch May 22, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants