BFCP: fix check on payload length and extract metadata#2854
Merged
Conversation
Collaborator
Author
|
@0xA50C1A1, could you take a look, please? |
Contributor
Perfect. What do you think about extracting the user ID and conference ID as metadata, could that be useful? |
0xA50C1A1
reviewed
May 26, 2025
Collaborator
Author
I don't know, but it would be trivial to do. I'll push a new version |
We should be able to identified this protocol on the first packet, without keeping any state Close ntop#2745
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to identified this protocol on the first packet, without keeping any state
Close #2745