refactor: 🛠 remove redundant logging imports and centralize logger configuration#1214
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
CI is failing due to unrelated download and HTTP errors. I believe a rerun should resolve it, as it’s not caused by the changes in this PR |
Collaborator
|
@onuralpszr Do you know what exit code 5 means? 🤔 |
Collaborator
Author
For that no test collected. let me send commit. |
fcakyon
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Centralized Logging Implementation:
SahiLoggerFormatterclass insahi/logger.pyto handle log formatting with color-coded levels and centralized configuration. The logger is now accessible asloggerfromsahi.logger.Codebase-Wide Logger Integration:
logging.getLogger(__name__)instances with imports of the centralizedloggerfromsahi.loggeracross multiple files, includingsahi/models/base.py,sahi/models/detectron2.py,sahi/models/mmdet.py, and others.