Skip to content

refactor: 🛠 remove redundant logging imports and centralize logger configuration#1214

Merged
fcakyon merged 5 commits into
obss:mainfrom
onuralpszr:refactor/logger
Jul 30, 2025
Merged

refactor: 🛠 remove redundant logging imports and centralize logger configuration#1214
fcakyon merged 5 commits into
obss:mainfrom
onuralpszr:refactor/logger

Conversation

@onuralpszr

Copy link
Copy Markdown
Collaborator

Centralized Logging Implementation:

  • Introduced a new SahiLoggerFormatter class in sahi/logger.py to handle log formatting with color-coded levels and centralized configuration. The logger is now accessible as logger from sahi.logger.

Codebase-Wide Logger Integration:

  • Replaced individual logging.getLogger(__name__) instances with imports of the centralized logger from sahi.logger across multiple files, including sahi/models/base.py, sahi/models/detectron2.py, sahi/models/mmdet.py, and others.

@onuralpszr

Copy link
Copy Markdown
Collaborator Author

Visual Test look

image

@onuralpszr

Copy link
Copy Markdown
Collaborator Author

CI is failing due to unrelated download and HTTP errors. I believe a rerun should resolve it, as it’s not caused by the changes in this PR

@fcakyon fcakyon self-requested a review July 30, 2025 20:37
@fcakyon

fcakyon commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

@onuralpszr Do you know what exit code 5 means? 🤔
CleanShot 2025-07-30 at 23 40 08@2x

@onuralpszr

Copy link
Copy Markdown
Collaborator Author

@onuralpszr Do you know what exit code 5 means? 🤔 CleanShot 2025-07-30 at 23 40 08@2x

For that no test collected. let me send commit.

@onuralpszr onuralpszr self-assigned this Jul 30, 2025
@fcakyon fcakyon added this pull request to the merge queue Jul 30, 2025
Merged via the queue into obss:main with commit 695d099 Jul 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants