Fix gnet.Conn not compatible with net.Conn on method Close#348
Merged
Conversation
…e func() error and change Close(AsyncCallback) to CloseWithCallback(AsyncCallback)
Codecov Report
@@ Coverage Diff @@
## dev #348 +/- ##
==========================================
- Coverage 72.50% 72.31% -0.20%
==========================================
Files 13 13
Lines 1371 1376 +5
==========================================
+ Hits 994 995 +1
- Misses 308 313 +5
+ Partials 69 68 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Owner
|
Thanks |
0-haha
added a commit
to 0-haha/gnet
that referenced
this pull request
Jan 25, 2023
…onn (panjf2000#348) Co-authored-by: 0-haha <0-haha@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.Conn 的Close() method的function signature是Close() error, 而gnet.Conn的Close() method的function signature是Close(callback AsyncCallback) error
现在把老的函数重命名成CloseWithCallback(callback AsyncCallback)
name: Fix gnet.Conn not compatible with net.Conn on method Close
about: Propose changes to the code
title: ''
labels: ''
assignees: ''
1. Are you opening this pull request for bug-fixes, optimizations or new feature?
Yes
2. Please describe how these code changes achieve your intention.
3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
4. Checklist