feat: add DialContext and EnrollContext for Client#543
Merged
Conversation
panjf2000
requested changes
Mar 14, 2024
Author
|
都改掉提交了 |
panjf2000
requested changes
Mar 15, 2024
panjf2000
left a comment
Owner
There was a problem hiding this comment.
startGnetClient 函数现在不需要 ev 了,直接移除掉吧。
还有其他的代码格式化问题也一起解决掉吧,不然 golangci-lint 会报错。
panjf2000
reviewed
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #543 +/- ##
==========================================
- Coverage 79.12% 79.00% -0.12%
==========================================
Files 25 25
Lines 2074 2091 +17
==========================================
+ Hits 1641 1652 +11
- Misses 299 304 +5
- Partials 134 135 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Author
|
存在的几个data race问题我也修复了下 |
Owner
|
你本地测过了没有? |
Author
|
测过了 |
panjf2000
requested changes
Mar 18, 2024
Author
|
改过了, 你看看 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541