Skip to content

test: Add pytest.traced, use unbuffered lines, and make check-style more strict#2165

Open
EricCousineau-TRI wants to merge 3 commits into
pybind:masterfrom
EricCousineau-TRI:feature-debug-help-upstream
Open

test: Add pytest.traced, use unbuffered lines, and make check-style more strict#2165
EricCousineau-TRI wants to merge 3 commits into
pybind:masterfrom
EricCousineau-TRI:feature-debug-help-upstream

Conversation

@EricCousineau-TRI

Copy link
Copy Markdown
Collaborator

Towards #1690

See this comment: #1690 (comment)

@wjakob

wjakob commented Apr 26, 2020

Copy link
Copy Markdown
Member

Hi @EricCousineau-TRI ,

quite a few details are missing for me to consider this PR (which should probably be split into seprate ones, one for each unrelated change). What does the change to check-style.sh accomplish (in which case is it stricter?) Note that there is an unresolved TODO in there. What about "traced" (there doesn't seem to be any usage of this new function). And what about the unbuffered -u flag? (We did not have any issues with this before, so why is it needed now?)

Thanks,
Wenzel

@wjakob

wjakob commented Jun 30, 2020

Copy link
Copy Markdown
Member

Ping? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants