Arm backend: Relax Qwen3 VL BF16 tolerance on Arm64#20450
Merged
zingo merged 1 commit intoJun 24, 2026
Conversation
Increase the TOSA BF16 atol for the Qwen3 VL full vision-model test on aarch64 only. Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com> Change-Id: I80add6c1dd9396e7730c56d43ccd4ddea4b0cfbc
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20450
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 2 Unrelated FailuresAs of commit 7cb9a05 with merge base 0fe2607 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Arm backend TOSA BF16 numeric tolerance for the Qwen3 VL vision full-model test when running on Arm64 hosts, to accommodate observed aarch64-specific BF16 mismatches while keeping non-aarch64 behavior unchanged.
Changes:
- Introduces an aarch64-only relaxed
atol(0.4) for the vision-model BF16 TOSA pipeline. - Keeps the default BF16 tolerance for other cases at
atol=0.1,rtol=0.1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sebastian-Larsson
approved these changes
Jun 24, 2026
Collaborator
Author
|
Test fails are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the TOSA BF16 atol for the Qwen3 VL full vision-model test on aarch64 only.
cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani