Skip to content

Arm backend: Relax Qwen3 VL BF16 tolerance on Arm64#20450

Merged
zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Relax-Qwen3-VL-BF16-tolerance-on-Arm64
Jun 24, 2026
Merged

Arm backend: Relax Qwen3 VL BF16 tolerance on Arm64#20450
zingo merged 1 commit into
pytorch:mainfrom
zingo:Arm-backend-Relax-Qwen3-VL-BF16-tolerance-on-Arm64

Conversation

@zingo

@zingo zingo commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Increase the TOSA BF16 atol for the Qwen3 VL full vision-model test on aarch64 only.

cc @digantdesai @freddan80 @per @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Increase the TOSA BF16 atol for the Qwen3 VL full vision-model test on
aarch64 only.

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I80add6c1dd9396e7730c56d43ccd4ddea4b0cfbc
Copilot AI review requested due to automatic review settings June 23, 2026 14:47
@zingo zingo requested a review from digantdesai as a code owner June 23, 2026 14:47
@zingo zingo added the release notes: none Do not include this in the release notes label Jun 23, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20450

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures, 2 Unrelated Failures

As of commit 7cb9a05 with merge base 0fe2607 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 23, 2026
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Arm backend TOSA BF16 numeric tolerance for the Qwen3 VL vision full-model test when running on Arm64 hosts, to accommodate observed aarch64-specific BF16 mismatches while keeping non-aarch64 behavior unchanged.

Changes:

  • Introduces an aarch64-only relaxed atol (0.4) for the vision-model BF16 TOSA pipeline.
  • Keeps the default BF16 tolerance for other cases at atol=0.1, rtol=0.1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zingo

zingo commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Test fails are unrelated

@zingo zingo merged commit 252f57c into pytorch:main Jun 24, 2026
499 of 518 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants