Refactor processing order#64
Conversation
|
Trying to find a good reason why my refactor might be a good reason to implement, since the results are the same either way (according to the tests), I did some performance benchmarks Executing the function 10000 times in succession results in the following for various available test fixtures. correct_sig_1.txt email_1.txt email_2.txt email_3.txt email_bullets.txt email_custom_quote_header.txt email_sig_delimiter_in_middle_of_line.txt While its unlikely that any script would perform these 10000 times in short succession, it does say that the refactor gives, in general, a slight performance improvement I actually feared the refactor might perform worse. I'm glad that is not the case. I also was expecting the most time to be lost on the regexes (which would perform the same in both versions). So this much time gained was unexpected |
|
This is very cool, thank you for that! |
I found it incredibly annoying that lines were processed in reverse (horizontal reverse).
So i thought i'd modify that
It still works based on line order from the last to the first but the actual lines itself are normally readable
If this commit is desirable please merge this pull request. Otherwise just close it.
If any changes are desired please let me know