fix: await analytics reporting methods#2443
Closed
cookesan wants to merge 1 commit into
Closed
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
Closing in favor of #2409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the public analytics reporting API return promises for
track,page,identify, andsetEnabled, matching the documentedawait analytics.track(...)usage. Foreground calls now resolve from a background-port acknowledgment after the background handler finishes, and reject when that handler fails.This also allows
analytics.page()with no location and keeps foreground metadata separate from optional analytics payload arguments.Linked Issues
fixes #2408
Checks
bun run --filter @wxt-dev/analytics test runbun run --filter @wxt-dev/analytics check../../node_modules/.bin/tsdownfrompackages/analyticsgit diff --check